Remote: Compressing objects: 100% (16/16), done. Hope my new eyes can help to clarify the doc and therefore make it easier for new contributors. Once you've cloned your fork to your computer, you're ready to start making edits! Once you've cloned the repo to your computer, you're ready to start making edits! So, it's not complete and the reader think we should go to Clone and initialize the repo to continue the setup. I think all the steps of the procedure should be mentioned in this section, or at least with a link to the proper section to build the project.įor example in the section Clone and initialize the repo, "Clone and initialize the repo" for what? It's not clear that part is not for contributing, may be we should mention something not to confuse with this section.Īlso, the section Making change does not mention anything about npm run init. ![]() This npm run init is not even mentioned in the section Making change. If there is a different procedure for Brave employees and a for contributors, that should be mentioned. You seem to tell the section Clone and initialize the repo is for Brave employees and the section Making change for contributors. I think the documentation should be clarified. Please let me know if that doesn't make sense In those cases you may need to edit the package.json specifically to have it point at your fork instead of brave-core (so that it uses your fork for init). There may be some work you need to do if your fork's branch diverges significantly from upstream (origin) or if you have patches. You can then check a new branch - or if you already have a branch, you can run the steps under Keeping your fork up to sync (which is a bad title, whoops) to bring your fork up to date If you're not needing to submit a PR, you can skip the Making changes sectionīy default, when running npm run init it'll check out the branch specified in package.json (which will be master on origin). Only Brave employees have access to push to brave/brave-core - so you'll need to push to your fork if you're hoping to submit a pull request. However- if you're actively making changes in a fork, you'll need to add YOUR remote to the src/brave repo. I believe I understand the disconnectīasically, all you need to do is run npm run init and src/brave will be setup for you. I was able to install using these steps, but it's a patch job and should probably have a real fix that part can look confusing, but it's correct. Then change the repo url and branch name to point to the brave-core version that has this change: So it scans for brave-core but never finds it because it is brave_core now.īrave-core to brave_core so when it scans for the repo url it can find it because it is now brave_core in brave-browser/package.json. ![]() That fixes it there, but then it breaks in brave-core which has its own getNPMConfig that does not do the same string replacement to change. So when brave-browser goes looking for brave-core in package.json, it can never find it because the key is changed to brave_core and it ends up undefined ![]() There is a string replacement that is making - into _ at Problem is that the path to the repository url is broken.
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |